From 57009d45040e92124fb4aefd59825d3525fd7d3a Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 12 May 2023 15:19:23 -0400 Subject: cmd/cgo/internal/testsanitizers: build on all platforms This test package uses the Pdeathsig field of syscall.SysProcAttr, which is only available on a few platforms. Currently, dist test checks for compatible platforms and only registers it as part of all.bash on platforms where it can build. But this doesn't help if you're just trying to type check everything in cmd. Make this package pass type checking by moving the condition from dist into build tags on the test package itself. For #60164. Updates #37486. Change-Id: I58b12d547c323cec895320baa5fca1b82e99d1b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/494658 Auto-Submit: Austin Clements Reviewed-by: Dmitri Shuralyov Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Run-TryBot: Austin Clements --- src/cmd/dist/test.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/cmd/dist/test.go') diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 8cd8abc19e..1d8125c51d 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -832,11 +832,7 @@ func (t *tester) registerTests() { if t.supportedBuildmode("plugin") { t.registerTest("cgo_testplugin", "", &goTest{pkg: "cmd/cgo/internal/testplugin", timeout: 600 * time.Second}) } - if goos == "linux" || (goos == "freebsd" && goarch == "amd64") { - // because Pdeathsig of syscall.SysProcAttr struct used in cmd/cgo/internal/testsanitizers is only - // supported on Linux and FreeBSD. - t.registerTest("cgo_testsanitizers", "", &goTest{pkg: "cmd/cgo/internal/testsanitizers", timeout: 5 * time.Minute}) - } + t.registerTest("cgo_testsanitizers", "", &goTest{pkg: "cmd/cgo/internal/testsanitizers", timeout: 5 * time.Minute}) if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" { t.registerTest("cgo_errors", "", &goTest{pkg: "cmd/cgo/internal/testerrors", timeout: 5 * time.Minute}) } -- cgit v1.2.3-54-g00ecf