From e181852dd487b97c0ed3662573793ca77f3299b0 Mon Sep 17 00:00:00 2001 From: Heschi Kreinick Date: Fri, 2 Feb 2018 16:26:58 -0500 Subject: cmd/compile/internal: use sparseSet, optimize isSynthetic changedVars was functionally a set, but couldn't be iterated over efficiently. In functions with many variables, the wasted iteration was costly. Use a sparseSet instead. (*gc.Node).String() is very expensive: it calls Sprintf, which does reflection, etc, etc. Instead, just look at .Sym.Name, which is all we care about. Change-Id: Ib61cd7b5c796e1813b8859135e85da5bfe2ac686 Reviewed-on: https://go-review.googlesource.com/92402 Reviewed-by: David Chase --- src/cmd/compile/internal/ssa/export_test.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/cmd/compile/internal/ssa/export_test.go') diff --git a/src/cmd/compile/internal/ssa/export_test.go b/src/cmd/compile/internal/ssa/export_test.go index d1d6831eb3..ac7a1b00e0 100644 --- a/src/cmd/compile/internal/ssa/export_test.go +++ b/src/cmd/compile/internal/ssa/export_test.go @@ -79,6 +79,10 @@ func (d *DummyAuto) StorageClass() StorageClass { return ClassAuto } +func (d *DummyAuto) IsSynthetic() bool { + return false +} + func (DummyFrontend) StringData(s string) interface{} { return nil } -- cgit v1.2.3-54-g00ecf