From c522b2bec9e6186a8efb7ddd221295390638a18e Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 21 Jul 2017 18:52:38 +0000 Subject: net/http: document that after Hijack, Request.Body is invalid We can make it panic with a more explicit and readable error message during Go 1.10, but document it for now. This has always been the case; it's not a new rule. Updates #20933 Change-Id: I53c1fefb47a8f4aae0bb32fa742afa3a2ed20e8a Reviewed-on: https://go-review.googlesource.com/50634 Reviewed-by: Ian Lance Taylor Reviewed-by: Emmanuel Odeke --- src/net/http/server.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/net/http/server.go b/src/net/http/server.go index a2c3acef50..2fa8ab23d8 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -178,6 +178,9 @@ type Hijacker interface { // // The returned bufio.Reader may contain unprocessed buffered // data from the client. + // + // After a call to Hijack, the original Request.Body should + // not be used. Hijack() (net.Conn, *bufio.ReadWriter, error) } -- cgit v1.2.3-54-g00ecf