From 9720aff0bcf876647cf064a4e92eeab43598bfc5 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 10 Jan 2020 09:25:51 -0500 Subject: [release-branch.go1.12] cmd/go/internal/modload: remove erroneous test case Commit e0cf3de987e6 of the vcs-test.golang.org/git/querytest repo includes a go.mod file specifying path vcs-test.golang.org/git/querytest.git, as does the latest commit. Since the repository also lacks v3 tags, a query for "latest" with a v3 path should fail. Due to a bug, that query does not fail as expected with Go 1.12. However, we do not need to continue to test for buggy behavior that was fixed in a subsequent release. Updates #36489 Change-Id: I766390c962fc75ba98fad02831310d90abf3055f Reviewed-on: https://go-review.googlesource.com/c/go/+/214281 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Dmitri Shuralyov --- src/cmd/go/internal/modload/query_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/cmd/go/internal/modload/query_test.go b/src/cmd/go/internal/modload/query_test.go index d6e52c6b74..2b4a871849 100644 --- a/src/cmd/go/internal/modload/query_test.go +++ b/src/cmd/go/internal/modload/query_test.go @@ -119,8 +119,6 @@ var queryTests = []struct { {path: queryRepoV2, query: "v0.0.1+foo", vers: "v2.0.0-20180704023347-179bc86b1be3"}, {path: queryRepoV2, query: "latest", vers: "v2.5.5"}, - {path: queryRepoV3, query: "latest", vers: "v3.0.0-20180704024501-e0cf3de987e6"}, - {path: emptyRepo, query: "latest", vers: "v0.0.0-20180704023549-7bb914627242"}, {path: emptyRepo, query: ">v0.0.0", err: `no matching versions for query ">v0.0.0"`}, {path: emptyRepo, query: " Date: Wed, 15 Jan 2020 06:38:16 -0800 Subject: [release-branch.go1.12] runtime: ignore power notification error seen on Windows Docker Updates #36557 Fixes #36574 Change-Id: Ia8125f382d5e14e5612da811268a58971cc9ac08 Reviewed-on: https://go-review.googlesource.com/c/go/+/214917 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick Reviewed-by: Jason A. Donenfeld Reviewed-by: Austin Clements (cherry picked from commit d2de9bd59c068c1bfcb4293de4286196dacf2e43) Reviewed-on: https://go-review.googlesource.com/c/go/+/215017 --- src/runtime/os_windows.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/runtime/os_windows.go b/src/runtime/os_windows.go index a278dddc57..a477f474f1 100644 --- a/src/runtime/os_windows.go +++ b/src/runtime/os_windows.go @@ -262,8 +262,9 @@ func loadOptionalSyscalls() { func monitorSuspendResume() { const ( - _DEVICE_NOTIFY_CALLBACK = 2 - _ERROR_FILE_NOT_FOUND = 2 + _DEVICE_NOTIFY_CALLBACK = 2 + _ERROR_FILE_NOT_FOUND = 2 + _ERROR_INVALID_PARAMETERS = 87 ) type _DEVICE_NOTIFY_SUBSCRIBE_PARAMETERS struct { callback uintptr @@ -301,6 +302,10 @@ func monitorSuspendResume() { // also have their clock on "program time", and therefore // don't want or need this anyway. return + case _ERROR_INVALID_PARAMETERS: + // This is seen when running in Windows Docker. + // See issue 36557. + return default: println("runtime: PowerRegisterSuspendResumeNotification failed with errno=", ret) throw("runtime: PowerRegisterSuspendResumeNotification failure") -- cgit v1.2.3-54-g00ecf From b293f01b4ae5d480c199d8126a26b88e6f997236 Mon Sep 17 00:00:00 2001 From: Alexander Rakoczy Date: Wed, 12 Feb 2020 11:32:58 -0500 Subject: [release-branch.go1.12] doc: document Go 1.12.17 Change-Id: I95f81f269e742ac058cb3e6404cc43beb2428926 Reviewed-on: https://go-review.googlesource.com/c/go/+/219200 Run-TryBot: Alexander Rakoczy TryBot-Result: Gobot Gobot Reviewed-by: Carlos Amedee --- doc/devel/release.html | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/devel/release.html b/doc/devel/release.html index 38a9040d5e..3349c43c8d 100644 --- a/doc/devel/release.html +++ b/doc/devel/release.html @@ -146,6 +146,12 @@ the crypto/x509 package. See the 1.12.16 milestone on our issue tracker for details.

+

+go1.12.17 (released 2020/02/12) includes a fix to the runtime. See +the Go +1.12.17 milestone on our issue tracker for details. +

+

go1.11 (released 2018/08/24)

-- cgit v1.2.3-54-g00ecf From 46cb016190389b7e37b21f04e5343a628ca1f662 Mon Sep 17 00:00:00 2001 From: Alexander Rakoczy Date: Wed, 12 Feb 2020 12:56:44 -0500 Subject: [release-branch.go1.12] go1.12.17 Change-Id: I9d398ed495011487544b1e5d0a469ae73c6f5927 Reviewed-on: https://go-review.googlesource.com/c/go/+/219218 Run-TryBot: Alexander Rakoczy TryBot-Result: Gobot Gobot Reviewed-by: Carlos Amedee --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 33bccfc8ee..b4936374dc 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -go1.12.16 \ No newline at end of file +go1.12.17 \ No newline at end of file -- cgit v1.2.3-54-g00ecf