From 27a3d30dd09cdd869b1b67f0154fa698bdf8ead2 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 8 Nov 2016 17:44:53 +0000 Subject: net/http: deflake TestClientRedirects Fix another case of a parallel test relying on a global variable (DefaultTransport) implicitly. Use the private Transport already in scope instead. It's closed at the end, instead of randomly via another test. Change-Id: I95e51926177ad19a766cabbb306782ded1bbb59b Reviewed-on: https://go-review.googlesource.com/32913 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/net/http/client_test.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index ba5602245b..2fe6e2164f 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -251,11 +251,14 @@ func TestClientRedirects(t *testing.T) { var checkErr error var lastVia []*Request var lastReq *Request - c = &Client{CheckRedirect: func(req *Request, via []*Request) error { - lastReq = req - lastVia = via - return checkErr - }} + c = &Client{ + Transport: tr, + CheckRedirect: func(req *Request, via []*Request) error { + lastReq = req + lastVia = via + return checkErr + }, + } res, err := c.Get(ts.URL) if err != nil { t.Fatalf("Get error: %v", err) -- cgit v1.2.3-54-g00ecf